[python-package] limit when num_boost_round warnings are emitted (fixes #6324) #6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Aug 2, 2024
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
StrikerRUS
requested changes
Aug 6, 2024
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
…into python/alias-warning
StrikerRUS
requested changes
Aug 27, 2024
StrikerRUS
approved these changes
Aug 29, 2024
|
Thanks for the thoughtful reviews @StrikerRUS ! |
|
@jameslamb Could you please remove python/alias-warning branch on RTD? I think we don't need to leave debug builds there.
|
|
🙈 sorry about that, thanks for your attention to detail! Just removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6324
Replaces #6548
num_iterationsis only raised if the user-provided configuration has conflicting valuesNotes for Reviewers
Just opening this to show I'm working on it. It still needs tests, and isn't ready for review yet.
How I tested this
Enabled this branch on readthedocs. See https://readthedocs.org/projects/lightgbm/builds/.
Isn't this kind of a lot of complexity for one parameter?
I think it's worth it. "number of boosting rounds" is one of the most important parameters for gradient boosting. I think it's worth handling it very carefully and raising an informative warning in the cases where conflicting configuration is provided. For example, I think this warning could save people from unnecessarily performing hyperparameter tuning over different combinations of
num_iterationsandnum_trees, not understanding that those mean the same thing in LightGBM's parameters.Why not use
pytest.parametrize()for all these tests?I started out that way, but then decided that it'd require enough if-else blocks and other logic that I was worried about accidentally, silently, mishandling some test cases.
I think the level of repetition in these test cases is ok, because it makes them easy to read and understand.